Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @storybook/[email protected], @testing-library/[email protected]

Cool, I tested this out in my pnpm vite project, and I was able to remove public-hoist-pattern[]=@types* from my .npmrc, since the latest jest-dom no longer uses definitely-typed, but publishes types itself.

In order for this to work correctly in vitest, we'll also need storybookjs/expect#77.

Hey @IanVS thanks a lot for this! I made a canary release of the expect changes in storybookjs/expect#77 and updated this PR (but it should be reverted later) so you can try out the canary release of this package

Thanks @yannbf, I tested it out, and it's working beautifully in my pnpm project, without the need to install the jest-dom types or hoist types in my .npmrc or anything like that.

That's great! so we can undo the commit where I changed the version of expect, I can do a proper release of expect and we can merge this. Before though, I wonder if you know whether there are any possible breaking changes with the upgrade?

I don't believe there are any breaking changes here. The breaking changes in jest-dom were the removal of an undocumented api that we don't use (extend-expect), and dropping node < 14. We could potentially remove https://github.com/storybookjs/jest#typescript-does-not-recognize-expecttobeinthedocument, or at least I should probably update it to not mention @types/testing-library__jest-dom since that is no longer used. I think the whole section can just be removed now though, because it just works out of the box. I'll push up a commit to this PR that does that.

🚀 PR was released in v0.2.2 🚀